Basic parametrized json export of prods #47
Conversation
|
Cool =) I'll take a look tonight or tomorrow. Any other review help is welcome. |
|
I gave it a quick shot and it's pretty cool, thx for this. One remark: I'm a little scared about the server if someone asks everything. Do you ming putting a max hard limit on it ? Like 100 ? I just don't want a script to be an easy way to kill scene.org. I'll do a more deep review this weekend. |
|
Oh also, I'm not sure about including the comments/ratings. There can be a lot per prod, but also we enter personal info ground here. I don't mind exporting a number of comments or avg rating though. Can we wait a little for comments/ratings ? I'm just not sure. |
|
Hard limit sounds good, I'll do that tomorrow. About the comments and ratings: I don't see a problem there since all the data is already available openly on the prod page itself and there's no other data involved. |
|
technically speaking if the data is already publically scrappable from the site it doesn't make sense to restrain it's access in the exporters also, if they just wanted the basic prod data there already are .xml.php scripts for that. legally speaking i have no clue who actually owns the data. we should ask a lawyer who is insider on the subject. maybe netpoet? i know that for example pouet is not compliant with the users right of being allowed to export their data and delete their presence and their data, and that this should be stated on a terms of service somewhere when registering not to mislead the users. it's just that we never cared about these legal issues before. i think this is a good opportunity to talk with someone who knows and legalize pouet in that respect. it's probably just a matter of new users having to accept a new TOS next time their login, or having to implement features that allow for user removal and data obfuscation. i'm weary of the later, since allowing users to edit/remove comments would completely break old conversation threads and even make the site somewhat useless if it applies to inserting prods and screenshots. but hei, if wikipedia and discogs can manage it, i'm pretty sure pouet can find a legal clause to protect itself and still allow users to syndicate data elsewhere. |
|
when i mentioned .xml.php scripts i was talking about these: |
|
psenough: the reason I wrote this export is because the currently available exports basically don't include any relevant data. To the (in my opinion non-issue) privacy thing: We could only allow export for logged in people with a valid scene_id or maybe even a trusted user level. It's not really necessary but if it helps to accept it into the codebase, I would not be against adding that. |
|
@dfox288 Thx for the patch For the comments, can you push a change to not include them yet ? I'll then test it and merge it, and we can give us more time to think about personal stuff to export. We can always add them later. I'm just not sure and don't want to do a mistake. |
|
Should be safe until we have a clear answer about the possible privacy issues. |
|
Merged in with some minor modifications, I hope you won't mind, I pushed them myself thinking that you'd like to see this live ASAP. |
...for people who don't wait for the API. Simple documentation inside.
Can be extended quite easily to export only prods by specific groups, platforms etc.