Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node6 is permafail #5102

Closed
daleharvey opened this issue Apr 27, 2016 · 6 comments
Closed

node6 is permafail #5102

daleharvey opened this issue Apr 27, 2016 · 6 comments

Comments

@daleharvey
Copy link
Member

All node tests, likely due to the 6x release
@daleharvey
Copy link
Member Author

So https://github.com/pouchdb/pouchdb/blob/master/tests/integration/test.attachments.js#L1268 is failing because the new version of node is generating different digests

daleharvey added a commit that referenced this issue Apr 27, 2016
@daleharvey
(#5102) - Use LTS node.js for now
1ad06b1
daleharvey added a commit that referenced this issue Apr 27, 2016
@daleharvey
(#5102) - Use LTS node.js for now
ac9b65b
daleharvey added a commit that referenced this issue Apr 27, 2016
@daleharvey
(#5102) - Use LTS node.js for now
dead3fa
daleharvey added a commit that referenced this issue Apr 27, 2016
@daleharvey
(#5102) - Add stable and .10 to allowed failures
c488ecf
daleharvey added a commit that referenced this issue Apr 28, 2016
@daleharvey
(#5102) - Fix missing body-parser package and do full build
9e7f989
@nolanlawson
Copy link
Member

very confusing since those digests match what's output by both CouchDB and spark-md5. 😕

@nolanlawson
Copy link
Member

might be related: nodejs/node#5522

daleharvey added a commit that referenced this issue Apr 28, 2016
@daleharvey
(#5102) - Use LTS node.js for now
b2895aa 
(#5102) - Use LTS node.js for now

* (#5102) - Add stable and .10 to allowed failures

* (#5102) - Fix missing body-parser package and do full build

* Try 5?
@daleharvey
Copy link
Member Author

Changed the title since we fixed travis putting it on 5

@daleharvey daleharvey changed the title Travis is permafail node6 is permafail Apr 28, 2016
omsmith added a commit to omsmith/pouchdb that referenced this issue Apr 29, 2016
@omsmith
(pouchdb#5102) - specify md5 data encoding
c3704f3 
The default encoding was switched to utf8 in nodejs/node#5522
@omsmith omsmith mentioned this issue Apr 29, 2016
Merged
@omsmith
Copy link
Contributor

omsmith commented Apr 29, 2016

Fix for test failures in #5107

You'll also see C/JS stack traces printed until Level/leveldown#280 is available

daleharvey added a commit that referenced this issue Apr 29, 2016
@daleharvey
(#5102) - Actually run stable tests
9ec5cea
omsmith added a commit to omsmith/pouchdb that referenced this issue Apr 29, 2016
@omsmith
(pouchdb#5102) - specify md5 data encoding
48bda89 
The default encoding was switched to utf8 in nodejs/node#5522
daleharvey pushed a commit that referenced this issue Apr 29, 2016
@omsmith @daleharvey
(#5102) - Specify md5 data encoding
3d7d497 
The default encoding was switched to utf8 in nodejs/node#5522
@daleharvey
Copy link
Member Author

Fixed in 3d7d497

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@daleharvey @nolanlawson @omsmith