-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove deprecation warnings for 1.13 #87
remove deprecation warnings for 1.13 #87
Conversation
@fivetanley, thanks for your attention to this. We are still trying to maintain backwards compatibility with the betas for the moment. Dropping backwards compatibility will require a major version bump. I've tried eliminating the 1.13 deprecation warnings while preserving backwards compatibility. I was able to do it for all of them except for the |
… thinking about it a little more, the event we were waiting for to drop backwards compatibility was, IIRC, ember-data releasing 1.0. Since that's happened now (and then some), maybe it's time for that major version bump. Anyone else have an opinion? |
I'm not sure what percentage of Ember users have upgraded to 1.0, but I do see the value in getting rid of old cruft to deal with <1.0 versions. Agree with @rsutphin that it would be a breaking change, though. |
Perhaps we can use ember-cli-version-checker to fix this? |
@broerse, we could do that, but we'd basically be maintaining two separate versions of the adapter then, just packaged together. Seems like if that's desirable we could just continue to maintain the 2.x line along with a new ED 1.13+-only 3.x line. My guess is that there is not sufficient interest to maintain both lines, regardless of how they are packaged. Does anyone have any objections to dropping compatibility with the ED betas? |
I am for dropping compatibility with the ED betas. But I think we must give an error like this: |
👍 on dropping support for ED betas. |
👍 I needed this branch for Ember 2.2.0 Ember Data 2.2.1. Woo hoo! Now it's working! |
I've posted a PR (#95) which incorporates this one and officially drops compatibility with ember & ember-data earlier than 1.13. |
fixes #78
This change will be incompatible with the betas of Ember Data, just fyi. Users will have to upgrade Ember Data as well.