Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecation warnings for 1.13 #87

Merged
merged 1 commit into from
Dec 13, 2015

Conversation

fivetanley
Copy link
Contributor

fixes #78

This change will be incompatible with the betas of Ember Data, just fyi. Users will have to upgrade Ember Data as well.

@rsutphin
Copy link
Collaborator

@fivetanley, thanks for your attention to this. We are still trying to maintain backwards compatibility with the betas for the moment. Dropping backwards compatibility will require a major version bump.

I've tried eliminating the 1.13 deprecation warnings while preserving backwards compatibility. I was able to do it for all of them except for the isDirty check. Do know of a technique for that one?

@rsutphin
Copy link
Collaborator

… thinking about it a little more, the event we were waiting for to drop backwards compatibility was, IIRC, ember-data releasing 1.0. Since that's happened now (and then some), maybe it's time for that major version bump. Anyone else have an opinion?

@nolanlawson
Copy link
Member

I'm not sure what percentage of Ember users have upgraded to 1.0, but I do see the value in getting rid of old cruft to deal with <1.0 versions. Agree with @rsutphin that it would be a breaking change, though.

@broerse
Copy link
Collaborator

broerse commented Aug 26, 2015

Perhaps we can use ember-cli-version-checker to fix this?

@rsutphin
Copy link
Collaborator

@broerse, we could do that, but we'd basically be maintaining two separate versions of the adapter then, just packaged together. Seems like if that's desirable we could just continue to maintain the 2.x line along with a new ED 1.13+-only 3.x line.

My guess is that there is not sufficient interest to maintain both lines, regardless of how they are packaged.

Does anyone have any objections to dropping compatibility with the ED betas?

@broerse
Copy link
Collaborator

broerse commented Aug 27, 2015

I am for dropping compatibility with the ED betas. But I think we must give an error like this:

mharris717/ember-cli-pagination@6781cde

@mattmarcum
Copy link
Contributor

👍 on dropping support for ED betas.

@openhouse
Copy link

👍 I needed this branch for Ember 2.2.0 Ember Data 2.2.1. Woo hoo! Now it's working!

@rsutphin
Copy link
Collaborator

rsutphin commented Dec 5, 2015

I've posted a PR (#95) which incorporates this one and officially drops compatibility with ember & ember-data earlier than 1.13.

@rsutphin rsutphin merged commit b943553 into pouchdb-community:master Dec 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation warnings coming from the change watcher with ED 1.13
6 participants