Skip to content

Commit

Permalink
Update simplecov version to 0.14.1
Browse files Browse the repository at this point in the history
Note: simplecov 0.14.0 fixed an issue that was breaking the example at
`spec/coveralls/simplecov_spec.rb:75`.

Before the result of `#get_source_files` for `fixtures/sample.rb` was:

```
00 COUNTED - # Foo class
01 COUNTED - class Foo
02 COUNTED -   def initialize
03 COUNTED -     @foo = 'baz'
04 COUNTED -   end
05 COUNTED -
06 COUNTED -   # :nocov:
07 SKIPPED -   def bar
08 SKIPPED -     @foo
09 SKIPPED -   end
10 COUNTED -   # :nocov:
11 COUNTED - end
```

Using simplecov 0.14.1, that includes
simplecov-ruby/simplecov#551, the result is:

```
00 COUNTED - # Foo class
01 COUNTED - class Foo
02 COUNTED -   def initialize
03 COUNTED -     @foo = 'baz'
04 COUNTED -   end
05 COUNTED -
06 SKIPPED -   # :nocov:
07 SKIPPED -   def bar
08 SKIPPED -     @foo
09 SKIPPED -   end
10 SKIPPED -   # :nocov:
11 COUNTED - end
```
  • Loading branch information
potomak committed Mar 19, 2017
1 parent 0c6e3aa commit e639c4c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion coveralls-ruby.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ Gem::Specification.new do |gem|
gem.required_ruby_version = '>= 1.8.7'

gem.add_dependency 'json', '>= 1.8', '< 3'
gem.add_dependency 'simplecov', '~> 0.12.0'
gem.add_dependency 'simplecov', '~> 0.14.1'
gem.add_dependency 'tins', '~> 1.6'
gem.add_dependency 'term-ansicolor', '~> 1.3'
gem.add_dependency 'thor', '~> 0.19.1'
Expand Down
2 changes: 1 addition & 1 deletion spec/coveralls/simplecov_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ def source_fixture(filename)
it "nils the skipped lines" do
source_file = source_files.first
source_file[:coverage].should_not eq result.files.first.coverage
source_file[:coverage].should eq [nil, 1, 1, 1, nil, 0, 1, nil, nil, nil]
source_file[:coverage].should eq [nil, 1, 1, 1, nil, 0, nil, nil, nil, nil, nil]
end
end
end
Expand Down

0 comments on commit e639c4c

Please sign in to comment.