Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong remote:scale argument parsing #66

Merged
merged 1 commit into from
Mar 2, 2019

Conversation

vsonnier
Copy link
Contributor

@vsonnier vsonnier commented Mar 1, 2019

Fix the remote:scale argument processing, removed the erroneous definition of scalar in SoapyRemote defs. Fix problem seen in Cubic while testing pothosware/SoapyPlutoSDR#19.

Now that #65 is in master, selecting the CS12 with scale 2048 shows the right scale for local CF32.

@guruofquality
Copy link
Contributor

Its documented as scalar too: https://github.com/pothosware/SoapyRemote/wiki

I think the getStreamArgsInfo() is just advertising it wrong. Its consistent everywhere else as scalar

Which leads to the question, which is better, scale or scalar?

@vsonnier
Copy link
Contributor Author

vsonnier commented Mar 1, 2019

@guruofquality Unless I got my English wrong, scalar just means number, one dimension opposed to vector which has many. scale means , well scale of a map, or range of any quantity so I vote for scale.

@guruofquality
Copy link
Contributor

It probably comes more down to "mathematics" jargon.

I will sleep on it :-P

@zuckschwerdt
Copy link
Member

For me as well versed but a non-native speaker (and btw mathematician) scalar sounds wrong. As Vincent quotes, scalar is just a number where scale hints at a proportion :)

@guruofquality guruofquality merged commit a6fbf2d into master Mar 2, 2019
@guruofquality guruofquality deleted the vso_fix_remote_scale_args branch March 2, 2019 16:37
@guruofquality
Copy link
Contributor

Well I guess if mathematics says its a bug.. Updated the wiki too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants