Changes to completion API #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teiesti
approved these changes
Nov 21, 2024
|
I approve these changes. However, I want to hear @ZachJHansen opinion. Regarding the failing tests. They are in beta and nightly and therefore not required for merging. Besides, a patch is already underway in one of the other pull requests so I would disregard them for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both the components function and the check for head mismatches are also needed for the implementation of ordered completion. Therefore, this PR moves the check for head mismatches into a function and makes both this function and the components function
pub(crate)so they can be reused.