Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format option for translate command #154

Closed
wants to merge 5 commits into from
Closed

Conversation

janheuer
Copy link
Collaborator

Adds a --format argument to the translate command with options default and tptp. The TPTP output also includes the preamble and all the type definitions and so on. For the TPTP output it is also possible to change wich role the formulas are given with the --role argument to either axiom or conjecture.

Copy link
Collaborator

@ZachJHansen ZachJHansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw a couple of typos (e.g. "prediates" instead of "predicates") but I have a more big-picture concern. I'm not sure it makes sense to include the standard preamble, types, transition axioms etc. as part of a format option for a first-order theory. This is adding semantic information to a syntactic operation. It also makes it asymmetric with the "default" option. Formatting an FOL theory should just format an FOL theory - I don't think it should mix instructions for a theorem prover into it. Since a tff statement in TPTP has the form tff(NAME, ROLE, FORMULA), all this format option should be doing is creating the FORMULA component.

@janheuer
Copy link
Collaborator Author

Tobias also already mentioned a few issues with the code and also had a similar big picture concern. So I guess we should first discuss what the format option really should do.

@janheuer janheuer closed this Nov 22, 2024
@teiesti
Copy link
Collaborator

teiesti commented Nov 22, 2024

@janheuer You might want to raise an issue so that we can discuss how we can support your use case and come up with ideas for potential features.

@teiesti
Copy link
Collaborator

teiesti commented Nov 22, 2024

Seems like we already have an issue: #90! Oops... Sorry!"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants