Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow the rejected slot to be non-scoped #17

Merged

Conversation

GerardRodes
Copy link
Contributor

@GerardRodes GerardRodes commented Jan 25, 2019

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

GerardRodes and others added 3 commits January 17, 2019 13:54
I'd like to introduce a rejected slot but without scoped data
@codecov-io
Copy link

codecov-io commented Jan 25, 2019

Codecov Report

Merging #17 into master will decrease coverage by 4.76%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
- Coverage     100%   95.23%   -4.77%     
==========================================
  Files           2        2              
  Lines          45       42       -3     
  Branches       16       16              
==========================================
- Hits           45       40       -5     
- Misses          0        2       +2
Impacted Files Coverage Δ
src/index.js 95% <81.81%> (-5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da14e44...61591c1. Read the comment docs.

@GerardRodes
Copy link
Contributor Author

I come frome here: #16
Sorry for creating a new PR, I'm more used to bitbucket than github

@posva
Copy link
Owner

posva commented Feb 25, 2019

Hey, actually, it would be nice to have this. Could you resolve the conflicts and push again please 🙏 ?

@GerardRodes
Copy link
Contributor Author

Resolved conflicts.

Copy link
Owner

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I need to do some modifications locally before releasing this like the old data passed to pending needing a test

@posva posva changed the title Feature/handle non scoped rejected slot feat: allow the rejected slot to be non-scoped Apr 27, 2019
@posva posva merged commit 0f439f7 into posva:master Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants