-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow the rejected slot to be non-scoped #17
feat: allow the rejected slot to be non-scoped #17
Conversation
I'd like to introduce a rejected slot but without scoped data
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
==========================================
- Coverage 100% 95.23% -4.77%
==========================================
Files 2 2
Lines 45 42 -3
Branches 16 16
==========================================
- Hits 45 40 -5
- Misses 0 2 +2
Continue to review full report at Codecov.
|
I come frome here: #16 |
Hey, actually, it would be nice to have this. Could you resolve the conflicts and push again please 🙏 ? |
Resolved conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I need to do some modifications locally before releasing this like the old data passed to pending needing a test
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: