Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Re-exposed the activate/deactivate methods on component #375

Merged
merged 1 commit into from
Jun 29, 2021
Merged

fix: Re-exposed the activate/deactivate methods on component #375

merged 1 commit into from
Jun 29, 2021

Conversation

DV8FromTheWorld
Copy link
Collaborator

@DV8FromTheWorld DV8FromTheWorld commented Jun 29, 2021 •
edited by posva
Loading

Fix #374

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • All tests are passing
  • New/updated tests are included

posva
posva approved these changes Jun 29, 2021
View reviewed changes
Copy link
Owner

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@posva posva linked an issue Jun 29, 2021 that may be closed by this pull request
Vue3 compatible version no longer exports activate and deactivate methods #374
Closed
@posva
Copy link
Owner

posva commented Jun 29, 2021 •
edited
Loading

Completely forgot the expose() function was already exposed!

@posva posva merged commit f5480ac into posva:next Jun 29, 2021
@DV8FromTheWorld DV8FromTheWorld deleted the fix/expose-focus-trap-methods branch June 30, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@posva posva posva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vue3 compatible version no longer exports activate and deactivate methods
2 participants
@DV8FromTheWorld @posva