Symbols on win32. #66
Conversation
| @@ -8,6 +8,12 @@ var jsface = require("jsface"), | |||
| */ | |||
| var Logger = jsface.Class({ | |||
| $singleton: true, | |||
|
|
|||
| symbols: { | |||
| err: (process.platform === "win32") ? "\u00D7 " : "✗ ", | |||
There was a problem hiding this comment.
This makes the check every time when printing out a log, can't we make the check once in the Helper using a export, to make sure its just loaded once? Like what mocha has done.
There was a problem hiding this comment.
So now even a if else on V8 is slow?
There was a problem hiding this comment.
Best practices, why load it every time, if you can do it only once ?
There was a problem hiding this comment.
So a new file / module that just exports symbols?
There was a problem hiding this comment.
Ok. I will add it in the helper.
On May 2, 2014 5:49 PM, "Arjun Variar" [email protected] wrote:
In src/utilities/Logger.js:
@@ -8,6 +8,12 @@ var jsface = require("jsface"),
*/
var Logger = jsface.Class({
$singleton: true,
+
- symbols: {
err: (process.platform === "win32") ? "\u00D7 " : "✗ ",Can't Helper do this?
—
Reply to this email directly or view it on GitHubhttps://github.com//pull/66/files#r12231810
.
|
@viig99 Added the ability to run tests on the request object. Test cases also attached. |
| headers: request.transformed.headers, | ||
| data: request.transformed.data, | ||
| form: request.transformed.form | ||
| }, |
There was a problem hiding this comment.
@a85: These is the request object that the user will be able to use in his tests. Is this okay?
|
@viig99 Refactored as per your comments. Now merge fast or 👊 |
No description provided.