Added support for chunked encoded requests when running gunicorn. #340 #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
httpbin/core.py
Outdated
| server = request.environ.get('SERVER_SOFTWARE', '') | ||
| if server.lower().startswith('gunicorn/'): | ||
| if 'wsgi.input_terminated' in request.environ: | ||
| app.logger.warning("environ wsgi.input_terminated already set, keeping: %s" |
There was a problem hiding this comment.
Is this really a warning level message? I'd consider this INFO or DEBUG at best.
There was a problem hiding this comment.
Yes debug is better and I have changed to that and rebased to master.
The original thinking of a louder log message was to quickly catch a change in gunicorn if it started adding input_terminated to requests, deprecating this middleware. But debug is fine for this.
postmanlabs#340. In this commit: - when we see a Transfer-Encoding: chunked request, and the server is gunicorn, we set environ wsgi.input_terminated, which is required by Werkzeug in the absence of Content-Lenght, or it will empty the data stream. - for chunked requests to non-gunicorn, return 501 Not Implemented.
javabrett
force-pushed
the
support-chunked-340
branch
from
74c58da to
ec79fee
Compare
|
✨🍰✨ |
virgiliojr94
pushed a commit
to virgiliojr94/httpbin-chat2desk
that referenced
this pull request
Jul 1, 2023
Added support for chunked encoded requests when running gunicorn. postmanlabs#340
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit:
we set environ wsgi.input_terminated, which is required by Werkzeug in the
absence of Content-Lenght, or it will empty the data stream.
Looking for guidance on the best way to set-up an acceptance/system test for this, since it cannot be verified through unit tests using FlaskClient.