Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check companion pairing authentication status code #2397

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Check companion pairing authentication status code #2397

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pyatv/protocols/companion/auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,10 @@ async def verify_credentials(self) -> bool:
},
)

# TODO: check status code
# check status code
if resp['_pd'][2] != 4:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit uncertain what this check really is? Isn't 2 here the same as

pyatv/pyatv/auth/hap_tlv8.py

Line 18 in 8d78f51

Salt = 0x02
?

_LOGGER.warning("companion pairing credentials are invalid")
raise exceptions.AuthenticationError("companion pairing credentials are invalid")

return True

Expand Down