-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support deploy in out-of-cluster mode #116
Merged
clementnuss
merged 7 commits into
postfinance:main
from
hansedong:support_out_of_cluster
Feb 21, 2023
Merged
feat: support deploy in out-of-cluster mode #116
clementnuss
merged 7 commits into
postfinance:main
from
hansedong:support_out_of_cluster
Feb 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hansedong <[email protected]>
hansedong
force-pushed
the
support_out_of_cluster
branch
from
February 20, 2023 11:41
a43095e
to
b2f6566
Compare
@clementnuss Could you please help review this PR? Thank you. |
clementnuss
approved these changes
Feb 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the PR!
Signed-off-by: hansedong <[email protected]>
hansedong
force-pushed
the
support_out_of_cluster
branch
from
February 21, 2023 06:19
0af7975
to
f9c2ce2
Compare
Pull Request Test Coverage Report for Build 4230668290
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has 2 features:
I use
kubelet-csr-approver
for automatic approve node serving certificates. I need it can be deployed in a K8s cluster in an out-of-cluster mode. Therefore, I hope it can support the-kubeconfig
flag to specify the kubeconfig file outside the cluster.When I specify kubeconfig flag, if the file does not exist, the program exits without any error message, which is obviously abnormal. The reason is that the
logger
is not initialized when the logic ofctrl.GetConfigOrDie()
is executed, so I refactored part of the code logic ininternal/cmd/cmd.go
.Now, it works fine for me with little code changes, and I look forward to receiving some suggestions for modifying this PR, thanks~