Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support deploy in out-of-cluster mode #116

Merged
merged 7 commits into from
Feb 21, 2023

Conversation

hansedong
Copy link
Contributor

This PR has 2 features:

  1. I use kubelet-csr-approver for automatic approve node serving certificates. I need it can be deployed in a K8s cluster in an out-of-cluster mode. Therefore, I hope it can support the -kubeconfig flag to specify the kubeconfig file outside the cluster.

  2. When I specify kubeconfig flag, if the file does not exist, the program exits without any error message, which is obviously abnormal. The reason is that the logger is not initialized when the logic of ctrl.GetConfigOrDie() is executed, so I refactored part of the code logic in internal/cmd/cmd.go.

Now, it works fine for me with little code changes, and I look forward to receiving some suggestions for modifying this PR, thanks~

@hansedong hansedong force-pushed the support_out_of_cluster branch from a43095e to b2f6566 Compare February 20, 2023 11:41
@hansedong
Copy link
Contributor Author

@clementnuss Could you please help review this PR? Thank you.

Copy link
Contributor

@clementnuss clementnuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR!

internal/cmd/cmd.go Outdated Show resolved Hide resolved
@hansedong hansedong force-pushed the support_out_of_cluster branch from 0af7975 to f9c2ce2 Compare February 21, 2023 06:19
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4230668290

  • 10 of 12 (83.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 75.893%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/controller/utils.go 10 12 83.33%
Totals Coverage Status
Change from base Build 4171556544: 0.4%
Covered Lines: 170
Relevant Lines: 224

💛 - Coveralls

@clementnuss clementnuss merged commit 3c55012 into postfinance:main Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants