Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Denies when hostname is not the dns name #76

Closed
challapradyumna opened this issue Aug 2, 2022 · 2 comments · Fixed by #87
Closed

Denies when hostname is not the dns name #76

challapradyumna opened this issue Aug 2, 2022 · 2 comments · Fixed by #87

Comments

@challapradyumna
Copy link

We explicity change the hostname of the box to a different naming convention the certificates get rejected because of this reason.

The SAN DNS Name in the x509 CSR is not prefixed by the node name (hostname)
@clementnuss
Copy link
Contributor

Ok, never thought about that use case.

I will implement a new command line flag to toggle this check 👍🏼

clementnuss added a commit that referenced this issue Aug 23, 2022
@clementnuss
feat: bypass hostname check
de7764d 
relates to #76
[skip ci]
clementnuss added a commit that referenced this issue Aug 23, 2022
@clementnuss
test: validate bypass hostname check behaviour
16732b2 
see #76
clementnuss added a commit that referenced this issue Aug 23, 2022
@clementnuss
feat: add --bypass-hostname-check config flag
1845906 
cf. #76
clementnuss added a commit that referenced this issue Aug 23, 2022
@clementnuss
docs: bypass-hostname-check explanation
38cf887 
cf. #76
[skip ci]
@clementnuss
Copy link
Contributor

hi @challapradyumna 👋🏻
I've implemented a config flag that permits to bypass the dns name is prefixed with the hostname check.

can you try the following image and report whether it works for you ?
postfinance/kubelet-csr-approver:bypass-hostname-check

@clementnuss clementnuss mentioned this issue Aug 29, 2022
Merged
clementnuss added a commit that referenced this issue Aug 29, 2022
@clementnuss
feat: bypass hostname check
f7f44c2 
relates to #76
[skip ci]
clementnuss added a commit that referenced this issue Aug 29, 2022
@clementnuss
test: validate bypass hostname check behaviour
68c6657 
see #76
clementnuss added a commit that referenced this issue Aug 29, 2022
@clementnuss
feat: add --bypass-hostname-check config flag
f22fefb 
cf. #76
clementnuss added a commit that referenced this issue Aug 29, 2022
@clementnuss
docs: bypass-hostname-check explanation
73ed5af 
cf. #76
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat/bypass hostname check postfinance/kubelet-csr-approver
2 participants
@challapradyumna @clementnuss