Node DNS name validation issue #181
Comments
hadi2f244
changed the title
|
salut @hadi2f244 I think the |
clementnuss
added a commit
that referenced
this issue
Aug 14, 2023
coolguy1771
referenced
this issue
in coolguy1771/home-ops
Sep 19, 2023
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [kubelet-csr-approver](https://togithub.com/postfinance/kubelet-csr-approver) | patch | `1.0.4` -> `1.0.5` | --- ### Release Notes <details> <summary>postfinance/kubelet-csr-approver (kubelet-csr-approver)</summary> ### [`v1.0.5`](https://togithub.com/postfinance/kubelet-csr-approver/blob/HEAD/CHANGELOG.md#105-2023-09-19) [Compare Source](https://togithub.com/postfinance/kubelet-csr-approver/compare/v1.0.4...v1.0.5) ##### Bug Fixes - **k8s-deploy**: set image tag to latest ([69e9249c](https://togithub.com/github.com/postfinance/kubelet-csr-approver/commit/69e9249c)) > closes [https://github.com/postfinance/kubelet-csr-approver/issues/178](https://togithub.com/postfinance/kubelet-csr-approver/issues/178) ##### Documentation - **readme**: add `--bypass-dns-resolution` information ([cb4d9bb6](https://togithub.com/github.com/postfinance/kubelet-csr-approver/commit/cb4d9bb6)) > [https://github.com/postfinance/kubelet-csr-approver/issues/181](https://togithub.com/postfinance/kubelet-csr-approver/issues/181) > > \[skip ci] ##### New Features - **common**: add changelog config and CHANGELOG.md ([bfb18012](https://togithub.com/github.com/postfinance/kubelet-csr-approver/commit/bfb18012)) > \[skip ci] ##### Tasks - **common**: update controller-runtime and fix linting errors ([9abb30ed](https://togithub.com/github.com/postfinance/kubelet-csr-approver/commit/9abb30ed)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi45Ny4xIiwidXBkYXRlZEluVmVyIjoiMzYuOTcuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: lumiere-bot <98047013+lumiere-bot[bot]@users.noreply.github.com>
szinn
referenced
this issue
in szinn/k8s-homelab
Sep 19, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [kubelet-csr-approver](https://togithub.com/postfinance/kubelet-csr-approver) | HelmChart | patch | `1.0.4` -> `1.0.5` | | [kubelet-csr-approver](https://togithub.com/postfinance/kubelet-csr-approver) | | patch | `1.0.4` -> `1.0.5` | --- ### Release Notes <details> <summary>postfinance/kubelet-csr-approver (kubelet-csr-approver)</summary> ### [`v1.0.5`](https://togithub.com/postfinance/kubelet-csr-approver/blob/HEAD/CHANGELOG.md#105-2023-09-19) [Compare Source](https://togithub.com/postfinance/kubelet-csr-approver/compare/v1.0.4...v1.0.5) ##### Bug Fixes - **k8s-deploy**: set image tag to latest ([69e9249c](https://togithub.com/github.com/postfinance/kubelet-csr-approver/commit/69e9249c)) > closes [https://github.com/postfinance/kubelet-csr-approver/issues/178](https://togithub.com/postfinance/kubelet-csr-approver/issues/178) ##### Documentation - **readme**: add `--bypass-dns-resolution` information ([cb4d9bb6](https://togithub.com/github.com/postfinance/kubelet-csr-approver/commit/cb4d9bb6)) > [https://github.com/postfinance/kubelet-csr-approver/issues/181](https://togithub.com/postfinance/kubelet-csr-approver/issues/181) > > \[skip ci] ##### New Features - **common**: add changelog config and CHANGELOG.md ([bfb18012](https://togithub.com/github.com/postfinance/kubelet-csr-approver/commit/bfb18012)) > \[skip ci] ##### Tasks - **common**: update controller-runtime and fix linting errors ([9abb30ed](https://togithub.com/github.com/postfinance/kubelet-csr-approver/commit/9abb30ed)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi45Ny4xIiwidXBkYXRlZEluVmVyIjoiMzYuOTcuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: repo-jeeves <106431701+repo-jeeves[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the Readme it is mentioned :
It is important to understand that the node DNS name needs to be resolvable for the kubelet-csr-approver to work properly. If this is an issue for you, please file an issue and I'll add a flag to disable this validation.For some situations like local clusters where there is no DNS server to map node to ip, this type of requirement makes CSR leave
Denied. So adding a related flag to disable this validation makes sense.The text was updated successfully, but these errors were encountered: