Skip to content

Commit

Permalink
doc: update helm install instruction
Browse files Browse the repository at this point in the history
  • Loading branch information
clementnuss committed Jan 18, 2022
1 parent 908812e commit 79def97
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
7 changes: 4 additions & 3 deletions .github/workflows/publish.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ jobs:
-e 's|tag:.*|tag: latest|g' \
-e 's|providerRegex:.*|providerRegex: ^.+$|g' \
-e 's|maxExpirationSeconds:.*|maxExpirationSeconds: "86400"|g' \
-e 's|bypassDnsResolution:.*|bypassDnsResolution: true|g' \
charts/kubelet-csr-approver/values.yaml
cat charts/kubelet-csr-approver/values.yaml
- name: Run chart-testing (install)
Expand Down Expand Up @@ -136,7 +137,7 @@ jobs:
run: |
export REF=${{ github.ref}}
export COMMIT=${{ github.sha}}
export TAG=$(echo ${{ github.ref }} | cut -d "/" -f 3 - )
export TAG=$(echo ${{ github.ref }} | cut -d "/" -f 3 - )
ko publish ./cmd/kubelet-csr-approver/ --base-import-paths --platform=linux/amd64,linux/arm64,linux/arm --tags $TAG
publish-helm-charts:
Expand All @@ -160,7 +161,7 @@ jobs:
run: |
git config user.name "$GITHUB_ACTOR"
git config user.email "[email protected]"
- name: Install Helm
uses: azure/setup-helm@v1
with:
Expand All @@ -187,7 +188,7 @@ jobs:
with:
go-version: 1.17
stable: true

- name: Login to DockerHub
uses: docker/login-action@v1
with:
Expand Down
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ helm repo add kubelet-csr-approver https://postfinance.github.io/kubelet-csr-app
helm install kubelet-csr-approver kubelet-csr-approver/kubelet-csr-approver -n kube-system \
--set providerRegex='^node-\w*\.int\.company\.ch$' \
--set maxExpirationSeconds='86400'
--set bypassDnsResolution='false'
```

## Attacker model -- what could go wrong ?
Expand Down

0 comments on commit 79def97

Please sign in to comment.