Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix class + element matches #8

Merged
merged 14 commits into from
Sep 6, 2016
Merged

Fix class + element matches #8

merged 14 commits into from
Sep 6, 2016

Conversation

yordis
Copy link
Contributor

@yordis yordis commented Sep 6, 2016

Related to #7 and MoOx/postcss-cssnext#287

@yordis yordis changed the title Add node_modules to git ignore Fix git ignore Sep 6, 2016
@yordis yordis changed the title Fix git ignore Fix git ignore and update packages Sep 6, 2016
@@ -35,7 +35,7 @@ rules:
computed-property-spacing: [2, "never"]

space-unary-ops: [2, {"words": true, "nonwords": false}]
space-after-keywords: [2, "always"]
keyword-spacing: [2, {"before": true, "after": true}]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MoOx I need your confirmation that this is the correct configuration. When I upgraded the package the configuration changed to this style. Please confirm that this is correct.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yordis yordis changed the title Fix git ignore and update packages Fix class + element matches Sep 6, 2016
@@ -33,7 +48,9 @@ function explodeSelector(selector, options) {

let newParts
if (postSelectors.length === 0) {
newParts = bodySelectors.map((s) => preWhitespace + pre + s)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually the issue right now. Because the pre is a class selector and s is an element selector we need to flip the concatenation.

}

function normalizeSelector(selector, preWhitespace, pre) {
selector = selector === undefined ? "" : selector
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MoOx why would I have a undefined selector?

@MoOx MoOx merged commit 9949a6d into postcss:master Sep 6, 2016
@MoOx
Copy link
Contributor

MoOx commented Sep 6, 2016

Thanks a lot

@MoOx MoOx mentioned this pull request Sep 6, 2016
@yordis
Copy link
Contributor Author

yordis commented Sep 6, 2016

@MoOx ups I was rebasing for squash the commit 😄

@MoOx
Copy link
Contributor

MoOx commented Sep 6, 2016

Can be done via github ui now ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants