Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correctly sort media queries before joining them #513

Merged
merged 3 commits into from
Dec 1, 2022
Merged

correctly sort media queries before joining them #513

merged 3 commits into from
Dec 1, 2022

Conversation

romainmenke
Copy link
Collaborator

@romainmenke romainmenke commented Dec 1, 2022 •
edited
Loading

fix : #512

This will not help with :

print and (min-width: 300px) + screen and (min-width: 300px)

RyanZim
RyanZim approved these changes Dec 1, 2022
View reviewed changes
Copy link
Collaborator

@RyanZim RyanZim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a perfect fix, but it solves the 90% use case with minimal complexity.

@RyanZim RyanZim merged commit 2db3239 into postcss:master Dec 1, 2022
@RyanZim RyanZim added the bug label Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanZim RyanZim RyanZim approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect media query concats
2 participants
@romainmenke @RyanZim