-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added support for postcss v8 #432
Conversation
I'm having the same CI errors than the previous PR. These errors are related with the source-map generation in windows (it seems like is about the directory separation). |
@oscarotero Looks like it's just a paths issue, there's an HTML file in |
I had to create a different sourcemap for windows to pass the tests, but it's working. |
@oscarotero Were you able to verify that the sourcemap generated on Windows works correctly on Windows? If not, that's fine, just curious. |
@RyanZim No, I don't have any Windows machine to verify that 😅 |
@RyanZim Anything I can help with to get this merged? |
Merged, need to do some other dependency upgrades before I release, but hopefully should be out this week. |
Sorry so long, finally released in v13 yesterday 🎉 |
Thanks man 🙌 |
Fixes #427
Supersedes #428
I did this changes following the plugin migration guide (https://evilmartians.com/chronicles/postcss-8-plugin-migration). I hope it helps.