Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PostCSS 6 #283

Merged
merged 4 commits into from
May 12, 2017
Merged

Use PostCSS 6 #283

merged 4 commits into from
May 12, 2017

Conversation

jonathantneal
Copy link
Member

@jonathantneal jonathantneal commented May 11, 2017

This PR updates PostCSS 6 and all dependencies. It is divided into separate commits, all of which individually pass testing.

Note: eslint did require removing the jspmResolve oddity.

- Updates .travis.yml to test Node (stable), Node 4.5
- Updates appveyor.yml to test Node 7, Node 4.5
- Update JS files to pass eslint-config-i-am-meticulous
- Update all tests, as they are now run relative to the package
directory via avajs/ava#1074
- Update plugins.js, as AVA requires an assertion
Copy link
Collaborator

@RyanZim RyanZim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; Thanks for doing this

@RyanZim
Copy link
Collaborator

RyanZim commented May 11, 2017

eslint-config-i-am-meticulous removed all stylistic rules in favor of prettier; so I'll have to figure out something there. Doesn't need changed for the release, though.
https://github.com/MoOx/eslint-config-i-am-meticulous/blob/master/CHANGELOG.md#600---2017-03-23

@RyanZim
Copy link
Collaborator

RyanZim commented May 11, 2017

I'll merge this as soon as I have a chance to release

@nickwaelkens
Copy link

Can't wait to get this one merged 👍

@RyanZim
Copy link
Collaborator

RyanZim commented May 12, 2017

Hopefully tonight

@RyanZim RyanZim merged commit c004710 into postcss:master May 12, 2017
@RyanZim
Copy link
Collaborator

RyanZim commented May 12, 2017

@jonathantneal Thanks a lot!

@jonathantneal jonathantneal deleted the feature/postcss6 branch May 12, 2017 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants