Properly clone nodes in ignoredAtRules
#24
Conversation
(fix postcss#21 when `parent` is undefined)
| ignoredAtRules.push([atRule, parsedAtImport]) | ||
| var atRuleCloned = atRule.clone() | ||
| atRuleCloned.parent = atRule.parent.clone() | ||
| ignoredAtRules.push([atRuleCloned, parsedAtImport]) |
There was a problem hiding this comment.
Why do we need this weird "clone but not really" ?
There was a problem hiding this comment.
I found out that atRule.removeSelf() changes the rule previously stored in ignoredAtRules. So I chose to clone node before storing it. I also cloned parent property because the clone() method doesn't make it.
Do you think of another way to do it ?
There was a problem hiding this comment.
I don't really know (or remember) why we do need a parent ref, but anyway, this is fixing a bug, with a test, so merging ^^
There was a problem hiding this comment.
Yep. Can you release a patch ?
There was a problem hiding this comment.
I am working a more stable release, but encountering too many weird behavior. This postcss API is starting to break my balls.
I will release a patch asap.
Properly clone nodes in `ignoredAtRules`
(fix #21 when
parentis undefined)