fix(multiselect): multyselect tag size #90 #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fork update
fix(select): fixing tag's height Tag's heigth was 28px (22 height + 2 border + 4 margin ), but select could handle only 26px tag. So tag's box-shadow was cutting out. Element's height was fixed and parent's padding was reseted for symmetry. Breaking Changes: none
fix(select): fixing mc-select__trigger_multiple margin-top Tag's heigth is 28px So the right padding should be 1px 7px 1px 15px, and compensation of borders seems unnecessary and was breaking symmetry. Breaking Changes: none
Margar1ta
changed the title
|
нужно вернуть выравнивание "дятла" по вертикали: и сделать тоже самое в tree-select. Похоже, что изначальная проблема была в нем: |
lskramarov
reviewed
Jul 17, 2019
packages/mosaic/select/select.scss
Outdated
| @@ -55,7 +55,7 @@ $mc-select-placeholder-arrow-space: 2 * ($mc-select-arrow-size + $mc-select-arro | |||
| cursor: pointer; | |||
|
|
|||
| // todo возможно нужно через JS | |||
| padding: 3px 7px 3px 15px; | |||
| padding: 1px 7px 1px 15px; | |||
There was a problem hiding this comment.
Есть ощущение, что вертикальные отступы уже не нужны, лучше их убрать.
fix(select): centering arrow #90 Arrow is centered and vertical padding is removed Breaking Changes: none
|
Вертикальные отступы и правда оказались не нужны, они убраны. Стрелка теперь четко по центру. |
lskramarov
reviewed
Jul 19, 2019
fix(select): code refactoring code refactoring Breaking Changes: none
lskramarov
approved these changes
Jul 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mikeozornin, проблема была в том, что тегу требуется 28 пикселей, а в select он обрезался родителем в 26px, а потому box-shadow, на который приходится 1px границы обрезался. Я увеличила высоту до 28px и изменила padding .mc-select__trigger - чтобы он укладывался в 30px элемента. А потом убрала margin-top - он ломал симметрию.