build: set Narwhals 1.9.1 as minimum, remove upper bound, use narwhals.stable.v1 for dtypes and typing #1717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very exciting that the dtypes made it into stable 🥳 Thank you! |
schloerke
added a commit
that referenced
this pull request
Oct 7, 2024
* main: tests(sidebar): Add tests for sidebar (#1715) tests(accordion): Add kitchensink tests for accordion (#1710) tests(bug): Use locator instead of element handles (#1716) tests(deploys): Move import from htmltools into code to help with debugging deploys (#1718) build: set Narwhals 1.9.1 as minimum, remove upper bound, use narwhals.stable.v1 for dtypes and typing (#1717) feat: support DataFrames via narwhals (#1570) Adds Deploy to Connect Cloud buttons to app READMEs (#1709)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey - as discussed in #1570, a blocker to not upper-bounding Narwhals was that
dtypesandtypingweren't available innarwhals.stable.v1We have now:
py-shinytest suite + type checking keeps working on every commitso I'd like to suggest removing the upper-bound
Thanks again for the collaboration here, it's been very rewarding to see this happen! 🤗