Run prettier format on vscode extension #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotNomad
requested review from
kgartland-rstudio,
mmarchetti,
sagerb and
tdstein
as code owners
sagerb
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
I don't much care for the single-quote to double-quote, but I understand the argument that it matches other languages for strings. If it becomes an issue, there is a configuration flag for this.
The whole point of prettier is that you are not supposed to care anymore.
Approving.
Base automatically changed from
dotnomad/vscode-prettier
to
prettier-introduction-integration-branch
March 21, 2024 18:08
sagerb
merged commit ef1b4ea
into
prettier-introduction-integration-branch
20 of 21 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Direct follow-up to #1178 which contains all of the formatting that
npm run format(prettier . --write') does.Intent
Part of #1030