stop trying to use R_Is_Running #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that with this PR, I can get Positron to successfully launch, but our good old friend zeromq has returned.
|
|
Fixed the zeromq issue with kevinushey/zeromq.js@d648694. |
jmcphers
approved these changes
Feb 15, 2023
wesm
pushed a commit
that referenced
this pull request
Mar 28, 2024
Merge pull request #176 from posit-dev/fix/issue-977 No longer monkey patch pydoc -------------------- Commit message for posit-dev/positron-python@63adb9d: remove monkey patches Authored-by: Pete Farland <[email protected]> Signed-off-by: Isabel Zimmerman <[email protected]>
wesm
pushed a commit
that referenced
this pull request
Mar 28, 2024
Merge pull request #176 from posit-dev/fix/issue-977 No longer monkey patch pydoc -------------------- Commit message for posit-dev/positron-python@63adb9d: remove monkey patches Authored-by: Pete Farland <[email protected]> Signed-off-by: Isabel Zimmerman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most interesting part of this PR is here:
https://github.com/rstudio/positron/compare/bugfix/linux-compile?expand=1#diff-ff5706db2eed01587e3786b377b19b745bfc159ac589162862856c8bc45f50ddR35
Effectively, we now use a broadcast channel (a bus) to broadcast that R has finished initialization to all consumers who may need to know.
This PR also moves from using
stdchannels tocrossbeamchannels. See #173 for motivation.Closes #171.
Closes #173.