Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Positron Build Number is 0 in DEB and RPM package version info #5159

Closed
sharon-wang opened this issue Oct 24, 2024 · 1 comment
Closed

Positron Build Number is 0 in DEB and RPM package version info #5159

sharon-wang opened this issue Oct 24, 2024 · 1 comment
Assignees
@sharon-wang
Labels
bug Something isn't working os-linux Linux issue packaging Issues related to packaging Positron (or components like Ark) for different package installers
Milestone
2024.11.0 Pre-Rel...

Comments

@sharon-wang
Copy link
Member

sharon-wang commented Oct 24, 2024 •
edited
Loading

System details:

Positron and OS details:

Builds containing 9a8f07a. Prior to this commit, we didn't include the BUILD_NUMBER in the package version info. Now that we include it, it revealed that we need to pass the calculated BUILD_NUMBER instead of the static value in product.json which is always 0.

Interpreter details:

N/A

Describe the issue:

Build number always shows 0 in DEB/RPM package version info output.

This is a follow-up to #1373.

Steps to reproduce the issue:

DEB

  1. Run dpkg --info <POSITRON_BINARY>.deb
  2. Version field in the output shows <POSITRON_VERSION>+0-<LINUX_REVISION>

Sample Output:

<SOME_INITIAL_INFO>
Package: positron
Version: 2024.11.0+0-1729709839
<REST_OF_INFO>

RPM

  1. Run rpm -qi <POSITRON_BINARY>.rpm
  2. Version field in the output shows <POSITRON_VERSION>+0

Sample Output:

Name        : positron
Version     : 2024.11.0+0
<REST_OF_INFO>

Expected or desired behavior:

Version info should contain the correct build number, which usually is not 0.

DEB

  1. Run dpkg --info <POSITRON_BINARY>.deb
  2. Confirm the Version field in the output shows <POSITRON_VERSION>+<BUILD_NUMBER>-<LINUX_REVISION>

Sample Output:

<SOME_INITIAL_INFO>
Package: positron
Version: 2024.11.0+999-1729709839
<REST_OF_INFO>

RPM

  1. Run rpm -qi <POSITRON_BINARY>.rpm
  2. Confirm the Version field in the output shows <POSITRON_VERSION>+<BUILD_NUMBER>

Sample Output:

Name        : positron
Version     : 2024.11.0+999
<REST_OF_INFO>

Were there any error messages in the UI, Output panel, or Developer Tools console?

N/A
@sharon-wang sharon-wang added bug Something isn't working os-linux Linux issue packaging Issues related to packaging Positron (or components like Ark) for different package installers labels Oct 24, 2024
@sharon-wang sharon-wang added this to the 2024.11.0 Pre-Release milestone Oct 24, 2024
@sharon-wang sharon-wang self-assigned this Oct 24, 2024
This was referenced Oct 24, 2024
Closed
Merged
sharon-wang added a commit that referenced this issue Oct 25, 2024
@sharon-wang
Fix version build number in DEB and RPM package info (#5140)
fa567b2 
### Summary

- addresses #5159
- related to #1373
- a follow-up to #5072 to fix
up the DEB and RPM package info build number

### Changes

- The `positronBuildNumber` from the package.json file will always be
zero -- instead, we need to use the calculated build number from
show-version.js when possible.
- We are already using the calculated build number in a few places, but
a few were missing, resulting in a build number of zero `0` in the DEB
and RPM package info.
- The `positronBuildVersion` variable is now in a separate util file, so
the value can be used across the gulpfiles.

### QA Notes

I've checked the version output of the DEB on Ubuntu 24 (x86_64) and the
RPM on Fedora 40 (arm).

#### DEB
1. Run `dpkg --info <POSITRON_BINARY>.deb`
2. Confirm the Version field in the output shows
`<POSITRON_VERSION>+<BUILD_NUMBER>-<LINUX_REVISION>`

Sample Output:
```
<SOME_INITIAL_INFO>
Package: positron
Version: 2024.11.0+999-1729709839
<REST_OF_INFO>
```

#### RPM
1. Run `rpm -qi <POSITRON_BINARY>.rpm`
2. Confirm the Version field in the output shows
`<POSITRON_VERSION>+<BUILD_NUMBER>`

Sample Output:
```
Name        : positron
Version     : 2024.11.0+999
<REST_OF_INFO>
```
@testlabauto
Copy link
Contributor

Verified Fixed

Positron Version(s) : 2024.11.0-129
OS Version          :  Ubuntu 24

Test scenario(s)

dpkg --info <POSITRON_BINARY>.deb
returns version information.

Link(s) to TestRail test cases run or created:

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sharon-wang sharon-wang

Labels
bug Something isn't working os-linux Linux issue packaging Issues related to packaging Positron (or components like Ark) for different package installers
Projects
None yet
Milestone
2024.11.0 Pre-Release
Development

No branches or pull requests
2 participants
@sharon-wang @testlabauto