Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable "Locker" or similar GH action #4143

Closed
juliasilge opened this issue Jul 24, 2024 · 5 comments
Closed

Enable "Locker" or similar GH action #4143

juliasilge opened this issue Jul 24, 2024 · 5 comments
Assignees
Labels
area: builds Issues related to Builds category.

Comments

@juliasilge
Copy link
Contributor

The "Locker" action is not currently running:

https://github.com/posit-dev/positron/actions/workflows/locker.yml

It would be helpful to get this or a similar action running so we can lock older issues and get folks to open new discussions, issues, etc.

Info to check out:
https://github.com/microsoft/vscode-github-triage-actions?tab=readme-ov-file#locker

I have not yet discovered what is locking our older PRs (see an example) but not our older issues.

@juliasilge juliasilge added the area: builds Issues related to Builds category. label Jul 24, 2024
@juliasilge juliasilge self-assigned this Jul 29, 2024
@juliasilge juliasilge added this to the 2024.08.0 Pre-Release milestone Jul 29, 2024
@juliasilge
Copy link
Contributor Author

Still not having a ton of luck finding out what is locking our PRs but not our issues. I thought maybe it was that we had "Automatically delete head branches" turned on for the repo, but I tested this out on pins by:

Notice that it deleted but it did not lock. I'll spend a bit more time on this but maybe in the end we just add something else that locks older issues without finding out what is happening to PRs, at least for now.

@juliasilge
Copy link
Contributor Author

I found it! 🙌

It's the CLA assistant: https://github.com/posit-dev/cla-assistant-github-action?tab=readme-ov-file#2-pull-request-event-triggers-cla-workflow

Specifically notice:

When the CLA workflow is triggered on pull request closed event, it will lock the Pull Request conversation after the Pull Request merge so that the contributors cannot modify or delete the signatures (Pull Request comment) later. This feature is optional.

I think we probably want to keep this feature, and when I add a new GH action, we will just apply it to issues.

juliasilge added a commit that referenced this issue Aug 6, 2024
Addresses #4143 

This PR uses [this very broadly used GH
action](https://github.com/dessant/lock-threads) to lock _closed_ issues
that have had no activity for 14 days.

It does not change the behavior around locking merged/deleted PRs, which
[is discussed more
here](#4143 (comment)).

### QA Notes

This GH action will help us keep folks from commenting on old, closed
issues.

> [!CAUTION]
> We have a lot (I mean, tons and tons) of old, closed issues. This
action will make a comment on _every single one of these_ and generate a
notification. It will process a bunch each day until it makes it through
the whole backlog of closed issues. I've gone through this on a few
other large repos and if you have notifications turned on, it is
extremely annoying for the first several days while it works through all
of them.

### Option 1

We leave this as is and just deal with the onslaught of notifications,
with the goal of getting to a better stage eventually. The disadvantage
here is pretty clear. 😩

### Option 2

We take _out_ the comment and only lock, which I believe does not
notify, possibly adding the comment in later, like next month sometime,
after the backlog is worked through. The disadvantage is that people can
feel quite put off when they find an old, locked issue that they feel is
relevant to their problem; the comment can help them know what to do.
@jonvanausdeln
Copy link
Contributor

Need to wait to verify this until the action has run a few times.

@juliasilge
Copy link
Contributor Author

This search will find issues we successfully locked:
https://github.com/search?q=repo:posit-dev/positron%20is:issue%20is:locked&type=issues

After running for one day, there are 50 locked, as expected; it does 50 per day.

@jonvanausdeln
Copy link
Contributor

Action ran last night, and locked as expected!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: builds Issues related to Builds category.
Projects
None yet
Development

No branches or pull requests

2 participants