Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix URLs used CI badge in README #553

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

rich-iannone
Copy link
Member

This PR addresses an issue brought up in the pyOpenSci review of Great Tables. The problem is that the CI build badge was seen to be in a broken state (stuck on "No Status". This is because the URLs used for the badge were malformed, and the changes here will fix that upon merging.

Fixes: #546

@rich-iannone rich-iannone marked this pull request as ready for review December 4, 2024 16:05
@rich-iannone rich-iannone requested a review from machow December 4, 2024 16:05
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.79%. Comparing base (ca56ddf) to head (c399158).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #553   +/-   ##
=======================================
  Coverage   89.79%   89.79%           
=======================================
  Files          45       45           
  Lines        5321     5321           
=======================================
  Hits         4778     4778           
  Misses        543      543           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rich-iannone rich-iannone merged commit ca10d70 into main Dec 4, 2024
13 of 14 checks passed
@rich-iannone rich-iannone deleted the docs-fix-readme-ci-badge branch December 4, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pyOpenSci review] README.md badge for CI status stuck on "No Status"
2 participants