Send LSP server init notification to frontend #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinushey
approved these changes
Aug 1, 2023
lionel-
force-pushed
the
feature/lsp-init-notif
branch
from
b6e92a2 to
4dab7ef
Compare
lionel-
force-pushed
the
feature/lsp-init-notif
branch
from
4dab7ef to
360f002
Compare
wesm
pushed a commit
to posit-dev/positron
that referenced
this pull request
Mar 28, 2024
Merge pull request #189 from posit-dev/feature/wait-lsp Sync LSP with positron-r -------------------- Commit message for posit-dev/positron-python@bdb0b65: Sync LSP with positron-r This makes the necessary changes to the Python LSP to keep it in sync with the following PRs for positron-r: - posit-dev/ark#71 - #934 - #1144 It improves the interaction between Positron and the LSP. Instead of Positron repeatedly trying to reconnect to the LSP server until it's ready, now Positron waits for the server to notify it with a `server_started` message over the LSP comm. I also made minor changes to `lsp.py` to add more logging and mark methods/attributes as private. I tested repeatedly restarting with `Cmd+Shift+0` ~20 times on Python 3.8 and 3.12 as well as refreshing with `Cmd+R` and all worked well. Authored-by: Wasim Lorgat <[email protected]> Signed-off-by: Wasim Lorgat <[email protected]>
wesm
pushed a commit
to posit-dev/positron
that referenced
this pull request
Mar 28, 2024
Merge pull request #189 from posit-dev/feature/wait-lsp Sync LSP with positron-r -------------------- Commit message for posit-dev/positron-python@bdb0b65: Sync LSP with positron-r This makes the necessary changes to the Python LSP to keep it in sync with the following PRs for positron-r: - posit-dev/ark#71 - #934 - #1144 It improves the interaction between Positron and the LSP. Instead of Positron repeatedly trying to reconnect to the LSP server until it's ready, now Positron waits for the server to notify it with a `server_started` message over the LSP comm. I also made minor changes to `lsp.py` to add more logging and mark methods/attributes as private. I tested repeatedly restarting with `Cmd+Shift+0` ~20 times on Python 3.8 and 3.12 as well as refreshing with `Cmd+R` and all worked well. Authored-by: Wasim Lorgat <[email protected]> Signed-off-by: Wasim Lorgat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move responsibility of sending LSP start notification from
LspCommtoShell::open_comm().The start notification message is now of type
server_startedinstead oflsp_started. This more general message type will be shared for all comms wrapping a server (e.g. DAP).The server notifies
open_comm()that it is ready to accept connections via a channel. The notification is then forwarded to the frontend through the comm. Before this change we were potentially sending the notification message too soon.