2022_Fischer_Gauls #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@93Boy this would be good if you could contribute! |
|
@93Boy can you please add your Janno file that you wrongly added to the recipes-repo here, to move this PR along? |
|
OK, so the fam file contains 49 individuals, but your Janno 125. Can you please check @93Boy ? |
This reverts commit 10c8af4.
Started filling out .janno for Fischer_Gauls
TCLamnidis
added
Final review needed
stschiff
reviewed
Dec 3, 2024
There was a problem hiding this comment.
Great! I have only two small comments:
- There are still a number of completely empty columns in the Janno file. I would propose to remove those. It's a bit off-putting to see so many
n/as. - The bib-file author list is formatted as one long line, and also contains lots of weird character tags that should be replaced with the proper Unicode symbols, I think. It's not useful to have these LaTeX encodings there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds package
2022_Fischer_GaulsLinked to poseidon-framework/minotaur-recipes#1
Publication is missing from the community archive, so metadata needs to be collected manually.