Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location Information correction #99

Closed
wants to merge 3 commits into from
Closed

Location Information correction #99

wants to merge 3 commits into from

Conversation

93Boy
Copy link
Contributor

@93Boy 93Boy commented Oct 7, 2022

Adding missing coordinations

@93Boy
Copy link
Contributor Author

93Boy commented Oct 26, 2022

@stschiff I have updated the cordinates you have sent me with commit #f559a89. I have found some mismatches with already existing data of 2018_FregelPNAS but I overwrote them considering these are the latest data.

@stschiff
Copy link
Member

stschiff commented Nov 2, 2022

OK, thanks for your changes. I think you have merge conflicts, though. Perhaps you can sort these out with @AyGhal? I think you have to pull in the latest changes on master first? @nevrome may be able to give a hint?

@93Boy
Copy link
Contributor Author

93Boy commented Nov 2, 2022

I have updated my PR before my commit. Yes I appreciate any help to sort this

@nevrome
Copy link
Member

nevrome commented Nov 3, 2022

Hey - this branch is 115 commits behind master. Where did you even find a branch that old to fork this from 😄 ? I suggest you make a new branch from master and add the coordinates there. Would probably be less of a pain than sorting this out. Make sure to always start from the head of the current master branch, @93Boy.

@93Boy
Copy link
Contributor Author

93Boy commented Nov 10, 2022

Opened a new PR under #105

@nevrome nevrome closed this Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants