Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed kinship errors in 2020_Coutinho_Neolithic and 2021_Novak_Croatia #187

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

93Boy
Copy link
Contributor

@93Boy 93Boy commented Jun 13, 2024

PR Checklist for modifying one or multiple existing packages

  • The changes maintain the structural integrity of the affected packages.
  • The checksums of the modified files in the respective POSEIDON.yml files were adjusted properly.
  • Every file in the submission is correctly referenced in the relevant POSEIDON.yml files and there are no additional, supplementary files in the submission that are not documented there.

  • The packageVersion numbers of the affected packages were increased in their POSEIDON.yml files.
  • The changes in the packageVersion followed the Poseidon Package versioning policy.
  • The changes were documented in the respective CHANGELOG files. If no CHANGELOG files existed previously it was added here.
  • The lastModified fields of the affected POSEIDON.yml files were updated.
  • The contributor fields were updated with name, email and orcid of the relevant, new contributors.
  • The .janno and the .ssf files are not fully quoted, so they only use single- or double quotes ("...", '...') to enclose text fields where it is strictly necessary (i.e. their entry includes a TAB).

  • All affected packages pass a validation with trident validate --fullGeno.

  • Large genotype data files are properly tracked with Git LFS and not directly pushed to the repository. For an instruction on how to set up Git LFS please look here. If you accidentally pushed the files the wrong way you can fix it with git lfs migrate import --no-rewrite path/to/file.bed (see here).

@stschiff stschiff self-requested a review June 14, 2024 08:04
Copy link
Member

@stschiff stschiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK thanks, changes look good, but the patch-version number needs to be increased.

@nevrome
Copy link
Member

nevrome commented Jul 12, 2024

@93Boy Could you please fill the checklist above?

@nevrome nevrome changed the title kinship error fixed kinship errors fixed in 2020_Coutinho_Neolithic and 2021_Novak_Croatia Jul 12, 2024
@nevrome nevrome changed the title kinship errors fixed in 2020_Coutinho_Neolithic and 2021_Novak_Croatia Fixed kinship errors in 2020_Coutinho_Neolithic and 2021_Novak_Croatia Jul 12, 2024
@stschiff
Copy link
Member

Update, @93Boy ?

@stschiff
Copy link
Member

stschiff commented Oct 9, 2024

@93Boy can you please fill the checklist and give a status update on whether this is ready to review?

@stschiff
Copy link
Member

stschiff commented Dec 3, 2024

@93Boy could you please finish this package, or indicate whether you need help?

@93Boy
Copy link
Contributor Author

93Boy commented Dec 9, 2024

Hello All , The requested changes has completed

@stschiff
Copy link
Member

OK, I made Changelog updates and bumped the versions to 1.0.0. This is read to merge, I think @AyGhal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants