-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed kinship errors in 2020_Coutinho_Neolithic and 2021_Novak_Croatia #187
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK thanks, changes look good, but the patch-version number needs to be increased.
@93Boy Could you please fill the checklist above? |
Update, @93Boy ? |
@93Boy can you please fill the checklist and give a status update on whether this is ready to review? |
@93Boy could you please finish this package, or indicate whether you need help? |
Hello All , The requested changes has completed |
OK, I made Changelog updates and bumped the versions to 1.0.0. This is read to merge, I think @AyGhal |
PR Checklist for modifying one or multiple existing packages
POSEIDON.yml
files were adjusted properly.POSEIDON.yml
files and there are no additional, supplementary files in the submission that are not documented there.packageVersion
numbers of the affected packages were increased in theirPOSEIDON.yml
files.packageVersion
followed the Poseidon Package versioning policy.CHANGELOG
files. If noCHANGELOG
files existed previously it was added here.lastModified
fields of the affectedPOSEIDON.yml
files were updated.contributor
fields were updated withname
,email
andorcid
of the relevant, new contributors..janno
and the.ssf
files are not fully quoted, so they only use single- or double quotes ("..."
,'...'
) to enclose text fields where it is strictly necessary (i.e. their entry includes a TAB).trident validate --fullGeno
.git lfs migrate import --no-rewrite path/to/file.bed
(see here).