Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2020 nakatsuka south patagonia #100

Merged
merged 4 commits into from
Jan 26, 2023
Merged

Conversation

93Boy
Copy link
Contributor

@93Boy 93Boy commented Oct 11, 2022

This is an updated version existing package under the same name

@nevrome
Copy link
Member

nevrome commented Oct 11, 2022

  • The file ter' should obviously not be there.
  • The package version number must be higher than the previous version.
  • Can you confirm that the sample order in the .bed file and in the .fam file (and therefore the .janno file) is certainly identical?

@93Boy
Copy link
Contributor Author

93Boy commented Oct 12, 2022

I did not change .bed file as I aligned .janno to the .fam file. But I'm curious about the .ter file as It's not in my local copy. The package version is lower as I have uploaded this as a new package, not as an updated version of the older package.

@nevrome
Copy link
Member

nevrome commented Oct 13, 2022

  • The ter' file must be there and you have to remove it. Maybe your file browser treats it as a hidden file and does not show it. Make sure to check with ls -a and remove it with rm. Then commit and push the change.
  • The package title is the same as the old package you want to replace. Therefore you have to give it a higher version number. Otherwise this package will break trident fetch. Newer package versions always need higher numbers.

@nevrome
Copy link
Member

nevrome commented Nov 4, 2022

I quickly fixed the two issues pointed out above. Should be good to go now. Nothing left to do, @93Boy. I took the monkey. And I will now hand it over to Ayshin 🐒 😄

Could you please do your final check and then merge (if everything is OK), @AyGhal?

@stschiff
Copy link
Member

stschiff commented Dec 9, 2022

@AyGhal the monkey is with you. Feel free to merge.

@AyGhal AyGhal merged commit d23316f into master Jan 26, 2023
@AyGhal
Copy link
Contributor

AyGhal commented Jan 26, 2023

Thanks.

@AyGhal AyGhal deleted the 2020_Nakatsuka_SouthPatagonia branch January 26, 2023 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants