Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build with network 3 #58

Merged
merged 2 commits into from
Sep 2, 2020
Merged

build with network 3 #58

merged 2 commits into from
Sep 2, 2020

Conversation

chessai
Copy link
Contributor

@chessai chessai commented Aug 25, 2020

No description provided.

@portnov
Copy link
Owner

portnov commented Aug 25, 2020

Hello.
Thanks for the contribution!
Did you check, will it still build with older versions?

@chessai
Copy link
Contributor Author

chessai commented Aug 25, 2020

I have not checked yet, only built and tested it with network 3.

@chessai
Copy link
Contributor Author

chessai commented Aug 25, 2020

Also I have no way to check windows, only linux and mac.

@portnov
Copy link
Owner

portnov commented Aug 25, 2020

I do not have windows either :)

It seems this fails on lts-12.14: https://travis-ci.org/github/portnov/libssh2-hs/jobs/721097209 (travis github integration is not working for some reason :/)

libssh2            > [4 of 5] Compiling Network.SSH.Client.LibSSH2.Foreign

libssh2            > 

libssh2            > /home/travis/build/portnov/libssh2-hs/libssh2/src/Network/SSH/Client/LibSSH2/Foreign.chs:85:32: error:

libssh2            >     Module ‘Network.Socket’ does not export ‘withFdSocket’

libssh2            >    |

libssh2            > 85 | 

libssh2            >    |                                ^^^^^^^^^^^^

libssh2            > 

@chessai
Copy link
Contributor Author

chessai commented Aug 30, 2020

@portnov try again? :)

@portnov
Copy link
Owner

portnov commented Aug 30, 2020

@chessai
Copy link
Contributor Author

chessai commented Sep 2, 2020

Any chance this could be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants