Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add derived data series to statements of assets chart #4396

Conversation

mierin12
Copy link
Contributor

Hello, same as #4235 that I was not able to maintain by rebase, I manage to be up to date by squashing its commits.
So now this PR present a single clear commit rather than an history of WIP commits that I could not maintain.

Goal : derived data series are available in the associated widget but it does not allow to compare different data series and is not customizable (color). By adding the derived data series to the statement of assets chart, this is possible.
Exemple : comparison of Delta of different data series :
2024-12-17 19_45_24-Paramètres

Based on #3754

buchen added a commit that referenced this pull request Dec 20, 2024
Uses DerivedDataSeries to hold a reference to the underlying data
series (base) and the aspect to be shown (ClientDataSeries).

Issue: #3754
Issue: #4235
Issue: #4396
Co-authored-by: Shivam Paw <[email protected]>
Co-authored-by: mierin12 <[email protected]>
Co-authored-by: Andreas Buchen <[email protected]>
@buchen
Copy link
Member

buchen commented Dec 20, 2024

@mierin12 thanks for the hard work in refactoring the change (and the patience to see it through).

I like the approach (new type, separate dialog).

Please have a look at #4403. Based your code, I did some more refactored:

  • First, I renamed the objects and types to be "derived" and "aspect" (similar to the widget on the dashboard)
  • Second, the DerivedDataSeries is now an object that holds the reference to the underlying data series (base) and the aspect to be used. This way, we can re-used the (potentially) already cached data series.
  • Third, I now create the data series based on the already created underlying data series.

If you have time, I would appreciate if you can have a look

@buchen buchen closed this Dec 20, 2024
buchen added a commit that referenced this pull request Dec 20, 2024
Uses DerivedDataSeries to hold a reference to the underlying data
series (base) and the aspect to be shown (ClientDataSeries).

Issue: #3754
Issue: #4235
Issue: #4396
Co-authored-by: Shivam Paw <[email protected]>
Co-authored-by: mierin12 <[email protected]>
Co-authored-by: Andreas Buchen <[email protected]>
buchen added a commit that referenced this pull request Dec 21, 2024
Uses DerivedDataSeries to hold a reference to the underlying data
series (base) and the aspect to be shown (ClientDataSeries).

Issue: #3754
Issue: #4235
Issue: #4396
Co-authored-by: Shivam Paw <[email protected]>
Co-authored-by: mierin12 <[email protected]>
Co-authored-by: Andreas Buchen <[email protected]>
buchen added a commit that referenced this pull request Dec 21, 2024
Uses DerivedDataSeries to hold a reference to the underlying data
series (base) and the aspect to be shown (ClientDataSeries).

Issue: #3754
Issue: #4235
Issue: #4396
Co-authored-by: Shivam Paw <[email protected]>
Co-authored-by: mierin12 <[email protected]>
Co-authored-by: Andreas Buchen <[email protected]>
buchen added a commit that referenced this pull request Dec 21, 2024
Uses DerivedDataSeries to hold a reference to the underlying data
series (base) and the aspect to be shown (ClientDataSeries).

Issue: #3754
Issue: #4235
Issue: #4396
Co-authored-by: Shivam Paw <[email protected]>
Co-authored-by: mierin12 <[email protected]>
Co-authored-by: Andreas Buchen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants