fix tick format of Payments charts #4385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This is a proposition to fix and simplify the tick format of Payments charts (use ThousandAmoundFormat for all payments charts).
Y axis tick format are defined as
ThousandsNumberFormatinPaymentsPerMonthChartBuilder,PaymentsPerYearChartBuilder,PaymentsPerQuarterChartBuilderbut also in the higher levelPaymentsChartTabwhere it is eitherThousandsNumberFormateitherAmountNumberFormat.It seems that the
PaymentsChartTaboverwrites the other ones.But it also does not update the format on tab switching : if you first open a chart with low values, such as Fees, then
AmountNumberFormatis set and then, even if you switch to Savings or a >1k chart, it will staysAmountNumberFormat:But is
AmountNumberFormatreally needed ? Since 3cb9ee1, the ThousandsNumberFormat is not adding "k" to <1000 values. So fine even for small value.AmountNumberFormat is more for tooltip I believe.
An even more simpler way than this PR would be to set the tick format as Thousands once in PaymentsChartTab and remove it in the four Payments charts (per month/quarter/year, accumulated). It should work too I guess.