Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix non visible 0% tick axis since the switch to swtchart 0.14 #4372

Closed
wants to merge 1 commit into from

Conversation

mierin12
Copy link
Contributor

Hello,

Issue : #4312 (comment)

Since switching to swtchart 0.14, the tick on chart axis for 0% does not appear anymore. As per the linked comment, it may be already fixed by swtchart but only available in the next release ? I am not sure.

I do not know why this works, but noticing than chart axis with the ThousandAmountFormat did not had this issue, I tried to use a similar approach. On my Windows it works. Maybe there is a simpler way to get it done ?

Before :
Capture d’écran 2024-11-29 214649 Capture d’écran 2024-11-29 214705 Capture d’écran 2024-11-29 214719 Capture d’écran 2024-11-29 214743

After :
Capture d’écran 2024-11-29 215029 Capture d’écran 2024-11-29 214404 Capture d’écran 2024-11-29 214307 Capture d’écran 2024-11-29 214439

Maybe the naming could be improved for maintainability point of view ? PercentNumberFormat -> AxisTickPercentNumberFormat ?

@buchen
Copy link
Member

buchen commented Nov 30, 2024

Very interesting fix. I really do not understand why this works, but it works.

I understand that SWTChart ist about to publish a 1.0.0 that would fix it, see eclipse/swtchart#410. But I plan to publish a new version this weekend. And that is a big change in an upstream library to include on such a short notice. The last release is 2 years old! I'll merge it and we can remove it once we adapt 1.0.0 .

I'll also take up your suggestion for renaming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants