Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add purchase price including fees and taxes in Statement of Assets and Security performance views #4310

Conversation

mierin12
Copy link
Contributor

@mierin12 mierin12 commented Oct 25, 2024

Closes #408
Closes #792
Issue : https://forum.portfolio-performance.info/t/entry-value-per-share-column-in-statement-of-assets-view/21680

Hello, this is a proposition to add the purchase price including the transactions fees and taxes in the Statement of Assets and Securities Performance view.
(is it correct to name it a "gross price" ?)

To not overload the menu (in particular in Statement of Assets), I have added a sub menu for purchase price, and to not have complicated names in the menu, ('Purchase price (moving average), Purchase price (moving average) (gross), Purchase price (FIFO), Purchase price (FIFO) (gross) ), I have added the possibility to add a LabelOnly message in the submenus. This could be reused.
I have added some MenuLabel for the FIFO purchase price to show "(FIFO)" in the menu. I think it looks cleaner.

Results :

  • Statement of Assets :
    2024-10-29 00_44_32-
  • Securities Performance views :
    2024-10-29 00_45_13-

This is the configuration that I prefer, but many other configurations are possible :

some tested config in the spoiler..

2024-10-26 01_10_34-Portfolio Performance
2024-10-18 23_18_40-
2024-10-18 23_38_03-
2024-10-18 23_44_04-
2024-10-18 23_45_24-
2024-10-18 23_51_37-
2024-10-24 22_37_34-Paramètres

@mierin12
Copy link
Contributor Author

mierin12 commented Nov 2, 2024

Additionaly, this is moving down a little bit the 'Purchase Value' of Securities Performance view menu, to be similar with the order from Statement of Assets menu (below Market Value). Very optional and only a matter of visual personal preference.

Maybe isin/symbol/wkn could be harmonized between the two views too.

@mierin12 mierin12 force-pushed the add_purchase_price_with_fees_and_taxes_in_statement_of_assets_and_securities_perf_view branch from b863b4f to b117697 Compare December 15, 2024 18:37
buchen pushed a commit that referenced this pull request Dec 22, 2024
Closes #792
Issue: #4310
Signed-off-by: mierin12 <[email protected]>
[renamed to column.heading; flipped label to 'taxes and fees']
Signed-off-by: Andreas Buchen <[email protected]>
@buchen
Copy link
Member

buchen commented Dec 22, 2024

Thanks for the pull request. I like the change.

Two small things I will change:

  • in other places it says "before taxes and fees". So I will switch the "fees and taxes" label around
  • rename the "labelOnly" to something like "sub-heading" of the column. That it is implemented as "LabelOnly" is one thing. But if we have a better dialog in the future, then heading can still work)

@buchen buchen closed this Dec 22, 2024
buchen added a commit that referenced this pull request Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Einstandskurs wird nicht korrekt berechnet Statement of assets' purchase price, but including commissions
2 participants