Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bigbank PDF Importer ignoring cent amounts #3891

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Fix Bigbank PDF Importer ignoring cent amounts #3891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aad4bb4
Modify Bigbank testcase to include cent amounts
MonkeySon Mar 27, 2024
be8e143
Fix Bigbank PDF importer
MonkeySon Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...io.tests/src/name/abuchen/portfolio/datatransfer/pdf/bigbank/BigbankPDFExtractorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,15 +46,15 @@ public void testKontoauszug01()
new AssertImportActions().check(results, CurrencyUnit.EUR);

// assert transaction
assertThat(results, hasItem(deposit(hasDate("2024-03-20"), hasAmount("EUR", 10.00), //
assertThat(results, hasItem(deposit(hasDate("2024-03-20"), hasAmount("EUR", 10.12), //
hasSource("Kontoauszug01.txt"), hasNote(null))));

// assert transaction
assertThat(results, hasItem(deposit(hasDate("2024-03-21"), hasAmount("EUR", 1500.00), //
assertThat(results, hasItem(deposit(hasDate("2024-03-21"), hasAmount("EUR", 1500.34), //
hasSource("Kontoauszug01.txt"), hasNote(null))));

// assert transaction
assertThat(results, hasItem(removal(hasDate("2024-03-25"), hasAmount("EUR", 10.00), //
assertThat(results, hasItem(removal(hasDate("2024-03-25"), hasAmount("EUR", 10.12), //
hasSource("Kontoauszug01.txt"), hasNote(null))));
}
}
12 changes: 6 additions & 6 deletions ...hen.portfolio.tests/src/name/abuchen/portfolio/datatransfer/pdf/bigbank/Kontoauszug01.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,14 @@ Kontoauszug von 01.03.2024 bis 25.03.2024
IBAN: EE123456789101112131
Anfangssaldo 01.03.2024 0,00
Datum Gegenkonto Buchung Name Betrag in EUR
20.03.2024 AT123456789101112131 Einzahlung ffIpWotyu dJMdyU +10,00
21.03.2024 AT123456789101112131 Einzahlung oDkoRVZEb TxDUxE +1 500,00
25.03.2024 AT123456789101112131 Auszahlung sUBHAKqzf vNNKxT -10,00
20.03.2024 AT123456789101112131 Einzahlung ffIpWotyu dJMdyU +10,12
21.03.2024 AT123456789101112131 Einzahlung oDkoRVZEb TxDUxE +1 500,34
25.03.2024 AT123456789101112131 Auszahlung sUBHAKqzf vNNKxT -10,12
Endsaldo 25.03.2024 1 500,00
Anfangssaldo 01.03.2024 0,00
Summe Belastungen -10,00
Summe Gutschriften +1 510,00
Endsaldo 25.03.2024 1 500,00
Summe Belastungen -10,12
Summe Gutschriften +1 510,46
Endsaldo 25.03.2024 1 500,34
Dies ist ein automatisch generierter Kontoauszug.
BIGBANK AS Telefon 0810 900 629
Riia 2, Tartu E-mail [email protected]
Expand Down
2 changes: 1 addition & 1 deletion name.abuchen.portfolio/src/name/abuchen/portfolio/datatransfer/pdf/BigbankPDFExtractor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,6 @@ private void addAccountStatementTransaction()
@Override
protected long asAmount(String value)
{
return ExtractorUtils.convertToNumberLong(value, Values.Amount, "de", "CH");
return ExtractorUtils.convertToNumberLong(value, Values.Amount, "et", "EE");
}
}
Loading