Modify Trade Republic PDF-Importer to support new transaction #3874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://forum.portfolio-performance.info/t/pdf-import-von-trade-republic/5107/489 Merge/Remove addLiquidationTransaction() Merge/Remove addCaptialReductionTransaction() Merge/Remove addCaptialReductionTransaction() Remove addDeliveryInOutBoundTransaction() Remove addTaxStatementTransaction(); Add addNonImportableTransaction() Add notes Fix testWertpapierVerkauf08() Rename test file USQuellensteuer01.txt to Steuerkorrektur01.txt There were previously some imports that were not solved correctly. For example, a SPIN-OFF was posted as a posting at 0.00. Also inbound/outbound deliveries which have no currency or amount are to be marked as NonImportable. The same applies to fiscal exchanges. Once without tax collection but delivery or derecognition has taken place without the currency of the security and taxes may have been offset. All in all, these are all special cases which we cannot import correctly and clearly.
Nirus2000
deleted the
Modify-Trade-Republic-PDF-Importer-to-support-new-transaction
branch
|
Hi Alex, BR Christian |
I asked in the forum how this should be booked, but now that you say it, it makes sense. |
Nirus2000
added a commit
that referenced
this pull request
May 3, 2024
…ery inbound Fix Trade Republic PDF-Importer to switch Save Back from Buy to delivery inbound #3874 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://forum.portfolio-performance.info/t/pdf-import-von-trade-republic/5107/489
Merge/Remove addLiquidationTransaction()
Merge/Remove addCaptialReductionTransaction()
Merge/Remove addCaptialReductionTransaction()
Remove addDeliveryInOutBoundTransaction()
Remove addTaxStatementTransaction();
Add addNonImportableTransaction()
Add notes
Fix testWertpapierVerkauf08()
Rename test file USQuellensteuer01.txt to Steuerkorrektur01.txt
There were previously some imports that were not solved correctly. For example, a SPIN-OFF was posted as a posting at 0.00. Also inbound/outbound deliveries which have no currency or amount are to be marked as NonImportable. The same applies to fiscal exchanges. Once without tax collection but delivery or derecognition has taken place without the currency of the security and taxes may have been offset. All in all, these are all special cases which we cannot import correctly and clearly.