Use collected sale/tax transactions to merge taxes into sale #3578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nirus2000
approved these changes
Oct 7, 2023
|
merging - as you cherry picked it into your branch, I believe you see this as okay :-) |
buchen
pushed a commit
that referenced
this pull request
Oct 7, 2023
…le (ComDirect) Refactors and optimizes the source TransactionPair replaces SaleTaxPair for matched transaction pairs Issue: #3578
buchen
added a commit
that referenced
this pull request
Oct 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #3555
@Nirus2000 - this pr uses the list of paired tax and sale transactions also for the merging. I think it could simplify the code: first, the items are already cases. Second, the hash map is not needed to keep the deleted items - we can delete them right away.