Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass empty string instead of null to prevent NPE #3563

Conversation

OnkelDok
Copy link
Member

@OnkelDok OnkelDok commented Sep 19, 2023

Because some commits ago we introduced the null checks (

public Configuration(String uuid, String name, String data)
{
this.uuid = Objects.requireNonNull(uuid);
this.name = Objects.requireNonNull(name);
this.data = Objects.requireNonNull(data);
}
) we now have to pass empty string instead of null.

In current version (with passing null) this leads to errors when creating an empty new portfolio file. You cannot save the new file. The "Save" or "Save as" menu entries are disabled.

@OnkelDok OnkelDok requested a review from buchen September 19, 2023 15:23
@buchen buchen merged commit 07f8525 into portfolio-performance:master Sep 23, 2023
@OnkelDok OnkelDok deleted the pass_empty_string_into_configuration_instead_of_null branch September 23, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants