Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Parse document properties with document sections #3556

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

buchen
Copy link
Member

@buchen buchen commented Sep 14, 2023

  • Allow for option/mandatory properties
  • Fail if the mandatory properties do not exist

@buchen buchen marked this pull request as draft September 14, 2023 08:54
@buchen
Copy link
Member Author

buchen commented Sep 14, 2023

@Nirus2000 have a look at the deutsche bank importer - this is how it could look like

(the pr needs some more polishing, but I would like your feedback first)

@Nirus2000
Copy link
Member

I like this... thx !!

* Allow for option/mandatory properties
* Fail if the mandatory properties do not exist

Issue: #3556
@buchen buchen force-pushed the feature_parse_document_properties_with_sections branch from 33e6b20 to 84f9765 Compare September 14, 2023 17:36
@buchen buchen marked this pull request as ready for review September 14, 2023 17:36
@buchen buchen merged commit 72700c5 into master Sep 14, 2023
@buchen buchen deleted the feature_parse_document_properties_with_sections branch September 14, 2023 17:51
buchen pushed a commit that referenced this pull request Sep 25, 2023
…e document context

Refactoring of PDF importers after adding required attributes from the document context (#3554 + #3556)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants