Modify deutsche bank pdf importer #3548 #3551
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest account statements cannot be imported because the currency was not detected. Apparently the latest document (can) introduce a line break between account number and final balance. With this change, the currency is retrieved from the header of the document. However, to enable this we need to check for two lines.
Modify Deutsche Bank PDF-Importer #3548
Nirus2000
force-pushed
the
Modify-Deutsche-Bank-PDF-Importer-#3548
branch
from
401e8b6 to
9e544a7
Compare
buchen
reviewed
Sep 14, 2023
| @@ -442,15 +445,14 @@ private void addAccountStatementTransaction() | |||
| if (t.getCurrencyCode() != null && t.getAmount() == 0) | |||
| item.setFailureMessage(Messages.MsgErrorTransactionTypeNotSupported); | |||
|
|
|||
| if (Boolean.valueOf(type.getCurrentContext().getBoolean("skipTransaction"))) | |||
There was a problem hiding this comment.
#getBoolean already returns a boolean. No need to convert it to a boolean via "Boolean#valueOf"
There was a problem hiding this comment.
i see it... i missing coffee in the morning. 🙈
buchen
added a commit
that referenced
this pull request
Sep 14, 2023
The latest account statements cannot be imported because the currency was not detected. Apparently the latest document (can) introduce a line break between account number and final balance. With this change, the currency is retrieved from the header of the document matching for the ISIN. Issue: #3551 #3548
buchen
pushed a commit
that referenced
this pull request
Sep 14, 2023
Issue: #3551 #3548 Signed-off-by: Nirus2000 <[email protected]> [moved change to currency matcher to separate commit; rebased to master] Signed-off-by: Andreas Buchen <[email protected]>
|
merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.