Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added namespace validation to prevent unwanted operations to pr… #70

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

stevensbkang
Copy link
Member

@stevensbkang stevensbkang commented Oct 4, 2023

This PR is to prevent unwanted operations from proceeding further.

kubectl create deployment nginx --image=nginx:latest -n doesntexist
error: failed to create deployment: namespaces "doesntexist" not found

It introduces a new middleware to add namespace validation and changes how all the API web services retrieve the namespace parameter.

Related to #68

@deviantony deviantony merged commit f2c3906 into develop Oct 5, 2023
1 check passed
@deviantony deviantony deleted the feat/add-ns-validation branch October 5, 2023 09:20
@deviantony deviantony linked an issue Oct 5, 2023 that may be closed by this pull request
5 tasks
@deviantony deviantony mentioned this pull request Oct 5, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Known issues for 1.0.0-beta
2 participants