feat(serf): introduce the ability to override probe timeout and interval [EE-2535] #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…us allow cli-params _and_ --help (#228) * feat(kingpin) use kingpin to parse ENV vars, and thus allow cli-params _and_ --help Signed-off-by: Sven Dowideit <[email protected]> * clean out unused env var names Signed-off-by: Sven Dowideit <[email protected]> * use the ENV text from the README Signed-off-by: Sven Dowideit <[email protected]> * HostManagementEnabled was hardcoded to true - I presume this was once a feature? Signed-off-by: Sven Dowideit <[email protected]> * do we need to store a copy of a bool we have access to? Signed-off-by: Sven Dowideit <[email protected]> * add the LogLevels to the flag options Signed-off-by: Sven Dowideit <[email protected]> * Don't try over-writing the existing /data/agent_edge_key - its 0444 Signed-off-by: Sven Dowideit <[email protected]> * feat(edge): rollback key retrieval changes * refactor(edge): remove comment * feat(main): rollback changes to ip detection * refactor(options): remove unused options * refactor(options): remove comment Co-authored-by: deviantony <[email protected]>
|
looks good, though I think the argument docs need to be more "only touch this if you actually know what it means" - and the use of cluster can be confused with the kube cluster :/ oh, and it needs a comment, in the code that uses is, telling the other devs what the point is, what a reasonable range is, and why someone would ever consider changing it (and i'm guessing @jamescarppe will want enough info on the that to make a "tuning advice" document) |
|
Closes #293 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes EE-2535
Takes over and replace #102