-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Handling of SSO Linking #907
Conversation
Previously, SSO account linking of existing accounts was possible for signed-out users. This commit disables that functionality. Users must now be signed into the app to link to an existing account.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good start.
There are a couple of places that could be improved.
This change adds the PR idea from #902. The change seeks to address the following issue: #900 Co-Authored-By: Omar Rodriguez Arenas <[email protected]>
Proposed English: |
Got back from translation - small rephrase on both - use these versions, please English: French: |
Link to approved text: #907 (comment)
To work properly, this test relies on the `current_user` method within `app/controllers/users/omniauth_callbacks_controller.rb`. Howerver, `current_user` is not currently behaving as expected there. Thus, the test is being commented out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Fixes #900
Changes proposed in this PR: