String changes to the SSO CILogon Sign-in button #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronskiba
changed the title
aaronskiba
requested changes
Sep 16, 2024
There was a problem hiding this comment.
The main update is correct.
However, we also have tests that correspond with the name of this button. Please update these as well.
Failures:
1) Openid_connection SSO with correct credentials creates account from external credentials
Failure/Error: click_link 'Sign in with CILogon'
Capybara::ElementNotFound:
Unable to find link "Sign in with CILogon"
# ./spec/integration/openid_connect_sso_spec.rb:29:in `block (3 levels) in <top (required)>'
The corresponding French translation of this text is too long to only be a single line long. To address that, `.html_safe` has been added here, which enables the correct behaviour when adding the `<br>` tag for the French translation on translation.io
aaronskiba
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #903 .
Changes proposed in this PR: Changes to the SSO CILogon Sing-in button