Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Favicons and Associated HTML Code #873

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Conversation

aaronskiba
Copy link
Collaborator

Changes proposed in this PR:

  • Update favicons to and associated html code
    • Favicon and HTML code generated via https://realfavicongenerator.net/

      • The previous favicon was also generated via https://realfavicongenerator.net/. (d646920) However, rather than public/android-chrome-192x192.png and public/android-chrome-256x256.png, this time only public/android-chrome-144x144.png was generated. The updated public/site.webmanifest reflects this change.

Also, due to the size of the provided favicon, https://realfavicongenerator.net/ outputted the following warning:

The strict minimum for the master picture is 70x70. Your picture is 150x150, which is ok. However, it is recommended to use a picture of at least 260x260. If you still want to use your picture, some of the derivated favicons will not be generated, such as the high resolution tile for Windows 8 / IE 11.

Favicon and HTML code generated via https://realfavicongenerator.net/

The previous favicon was also generated via https://realfavicongenerator.net/ . However, rather than `public/android-chrome-192x192.png` and `public/android-chrome-256x256.png`, this time only `public/android-chrome-144x144.png` was generated. The updated `public/site.webmanifest` reflects this change.

Also, due to the size of the provided favicon, https://realfavicongenerator.net/ outputted the following warning:
```
The strict minimum for the master picture is 70x70. Your picture is 150x150, which is ok. However, it is recommended to use a picture of at least 260x260. If you still want to use your picture, some of the derivated favicons will not be generated, such as the high resolution tile for Windows 8 / IE 11.
```
Copy link
Collaborator

@200455939-yashu 200455939-yashu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Work 👏

Copy link
Collaborator

@200455939-yashu 200455939-yashu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work 👏

@aaronskiba aaronskiba merged commit bc836bf into integration Aug 30, 2024
11 checks passed
@aaronskiba aaronskiba deleted the aaron/favicon branch August 30, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants