Testcases for the Ominiauth controller openid connect #869
Conversation
…ix' into yashu-controller-spec
…shu-controller-spec
| # Mock OmniAuth data for OpenID Connect with necessary info | ||
| OmniAuth.config.mock_auth[:openid_connect] = OmniAuth::AuthHash.new({ | ||
| provider: 'openid_connect', | ||
| uid: '12345', | ||
| info: { | ||
| email: '[email protected]', | ||
| first_name: 'Test', | ||
| last_name: 'User', | ||
| name: 'Test User' | ||
| } | ||
| }) |
There was a problem hiding this comment.
We don't need to define this here since it is already on spec_helper.rb
Lines 126 to 136 in 4da5fdd
| context 'when the email is missing and the user does not exist' do | ||
| before do | ||
| # Simulate missing email | ||
| OmniAuth.config.mock_auth[:openid_connect].info.email = nil |
There was a problem hiding this comment.
Should we reset the email after this test in case we use it in another test?
There was a problem hiding this comment.
In this test case, we want to ensure it returns a 'nil' value. Replacing the values will not guarantee the nil results.
| def User.from_omniauth(_auth) | ||
| nil | ||
| end |
There was a problem hiding this comment.
How does monkey patching this method work here? Will it be reset after the tests are done ? Or do we need to reset it for the rest of the tests ?
There was a problem hiding this comment.
Could we change the values we are using to get the nil value as a return instead of monkey patching this method ?
| def User.from_omniauth(_auth) | ||
| User.find_by(email: '[email protected]') | ||
| end | ||
|
|
||
| def IdentifierScheme.find_by_name(provider_name) | ||
| IdentifierScheme.find_by(name: provider_name) | ||
| end |
There was a problem hiding this comment.
Same question about monkey patching these methods. Do we need to reset them ?
| User.define_singleton_method(:from_omniauth) do |_auth| | ||
| nil | ||
| end |
There was a problem hiding this comment.
Same question about monkey patching
|
|
||
| it "links identifier to current user, sets flash notice, and redirects to root path" do | ||
| expect { | ||
| get :openid_connect |
There was a problem hiding this comment.
I'm confused why get :openid_connect is working.
get :openid_connect seems to behave like post :openid_connect within these tests, but the same is not true outside of the tests.
There was a problem hiding this comment.
updated this
| RSpec.describe Users::OmniauthCallbacksController, type: :controller do | ||
| before do | ||
| # Enable test mode for OmniAuth | ||
| OmniAuth.config.test_mode = true |
There was a problem hiding this comment.
spec/spec_helper.rb:124 of yashu-sso-link-accounts also has OmniAuth.config.test_mode = true. Do we need the same statement here?
There was a problem hiding this comment.
updated this
| get :openid_connect | ||
|
|
||
| expect(flash[:alert]).to eq( | ||
| "The current #{@identifier_scheme.description} iD has been already linked to a user with email #{different_user.email}" |
There was a problem hiding this comment.
This should probably be updated to match the changes you made in app/controllers/users/omniauth_callbacks_controller.rb:57
There was a problem hiding this comment.
String value is going to be same as expected here. I have changed the way of passing the variable into this string.
Fixes # .
Changes proposed in this PR: Adding the Testcases for the Omniauth Controller for the openid_connect.